Re: [PATCH v1] Fix initial sync of zero-column published tables

On Thu, Nov 5, 2026 at 1:48 PM Mingjie Gao <mingjie(dot)gmj(at)gmail(dot)com> wrote:
...
> Please find the updated v2 patch attached.
>

Some minor comments for the v2 test code.

======
src/test/subscription/t/008_diff_schema.pl

1.
+ CREATE PUBLICATION pub_nocols FOR TABLE tab_nocols
+ WITH (publish = 'insert');

Saying publish = 'insert' seems overkill.

~~~

2.
+ $node_subscriber->safe_psql('postgres', 'DROP SUBSCRIPTION sub_nocols');
+ $node_publisher->safe_psql('postgres',
+ 'DROP PUBLICATION pub_nocols; DROP TABLE tab_nocols');
+ $node_subscriber->safe_psql('postgres', 'DROP TABLE tab_nocols');

Those could be combined a bit...

~~~

3. Other misc refactoring

some spaces
some comments
some more consistent use of terminating ';'
etc.

~~~

I've made a few tmp changes (only cosmetic -- nothing functional).
e.g., see my attached version of the 008_diff_schema.pl changes for reference.

======
Kind Regards,
Peter Smith.
Fujitsu Australia