Re: [PATCH v1] Fix initial sync of zero-column published tables

Hi Peter,

Thanks for reproducing the issue and testing the patch.

> Now that BeginCopyFrom is just a thin "wrapper" should all that
> commentary describing each of the function parameters be moved to
> BeginCopyFromExtended function-comment where all the work is done?

Agreed. I've moved the parameter descriptions to the comment for
BeginCopyFromExtended().

> The TAP test code for this patch seems more elaborate than usual.
> AFAIK it is normal to accept that regressions show up as a timeout.

I've simplified the test to use wait_for_subscription_sync(). It still
checks both text and binary modes, and retains the incremental insert check
alongside the initial sync check.

Please find the updated v2 patch attached.

Best regards,
mingjiegao