| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Xiaopeng Wang <wxp_728(at)163(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add missing period to DETAIL messages |
| Date: | 2026-04-15 07:41:10 |
| Message-ID: | CAHut+PsaMX=CF6ASFVyg_mmmz0McDACvNHdV4z77WPE63+YC9Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 15, 2026 at 3:48 PM Xiaopeng Wang <wxp_728(at)163(dot)com> wrote:
>
...
>
> Looks good to me.
>
> A small comment is that, the commit message claims only “add missing period to DETAIL messages”, but apparently the patch also changes capitalization in many places, so the commit message should be updated.
>
Fair point. Thanks for your review!
PSA v4 which has an improved commit message.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-DETAIL-messages-fix-capitalization-and-add-missin.patch | application/octet-stream | 33.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2026-04-15 08:18:28 | Re: [PATCH] Miscellaneous little fixes |
| Previous Message | Pavel Stehule | 2026-04-15 07:39:28 | Re: proposal - queryid can be used as filter for auto_explain |