Re: [PATCH] Miscellaneous little fixes

From: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
To: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: [PATCH] Miscellaneous little fixes
Date: 2026-04-15 08:18:28
Message-ID: CAJ7c6TOSsHZY14wNYxk4DRr01wvaQ9fwS=W3Zbpt7B84TNyWig@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Michael,

Thanks for picking this up.

> There is no cost in keeping it, and removing it could break some
> extension code out there..

Of course it's up to you to decide, but I wanted to point out the
comment written in 2014 says:

/* Remove me eventually */

... soooooo. IMO 12 years is quite enough for eventually and for a
line of code that is not covered by any tests :)

--
Best regards,
Aleksander Alekseev

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message 胡传文 2026-04-15 08:28:44 [PATCH] Fix wrong comment in JsonTablePlanJoinNextRow()
Previous Message Peter Smith 2026-04-15 07:41:10 Re: Add missing period to DETAIL messages