| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Takeshi Ideriha <iderihatakeshi(at)gmail(dot)com> |
| Subject: | Re: DOCS - CREATE PUBLICATION wording re 'ONLY' for partitioned tables. |
| Date: | 2026-10-19 21:34:31 |
| Message-ID: | CAHut+PsJQutKrsS3HOFYm+OJiAf74xaaUFCXoS9fR18WMU9bEg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 19, 2026 at 7:49 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Mon, Oct 19, 2026 at 1:42 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> >
...
> > I think this is an improvement by making the meaning of ONLY and * clearer.
> >
> > I just have nit comment:
> > ```
> > + the publication, so they are never explicitly added to the publication.
> > ```
> >
> > “so they are never explicitly added to the publication” might be read as a child partition cannot be added explicitly, however I verified the following is valid:
> > ```
> > CREATE TABLE p (id integer) PARTITION BY RANGE (id);
> > CREATE TABLE p1 PARTITION OF p FOR VALUES FROM (0) TO (100);
> > CREATE PUBLICATION pub FOR TABLE p, p1;
> > ```
> >
> > So, how about:
> > ```
> > the publication, so they do not need to be explicitly added to the
> > publication.
> > ```
>
> +1. I had the same thought while reviewing. Although the goal here is
> just to clarify the point about ONLY, we can also make the subsequent
> sentence less ambiguous in the same patch.
>
Hi Chao and Shveta.
Thanks for your review comments. I agree with you.
PSA patch v2, which also fixes the misleading "never" wording in the
original sentence.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-DOCS-Remove-ambiguous-wording-about-ONLY-for-part.patch | application/octet-stream | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2026-10-19 21:39:51 | Re: regress: query discrepancy between explain vs execution |
| Previous Message | Mario González | 2026-10-19 21:24:24 | Re: [PATCH] Add support for INSERT ... SET syntax |