| From: | Takeshi Ideriha <iderihatakeshi(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DOCS - CREATE PUBLICATION wording re 'ONLY' for partitioned tables. |
| Date: | 2026-10-20 02:15:58 |
| Message-ID: | b0dcc41c-19b9-40db-a915-236f9fcf9141@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all
> Thanks for your review comments. I agree with you.
>
> PSA patch v2, which also fixes the misleading "never" wording in the
> original sentence.
Thank you for creating another thread per my suggestion.
The patch V2 looks good to me.
It's completely optional but I noticed that ALTER PUBLICATION doc [1]
also mentions ONLY and '*' though ALTER PUBLICATION doc does not mention
partitioned table at all. How about adding the similar note to ALTER
doc? I know the main purpose of this patch is to remove ambiguous
sentence from CREATE PUBLICATION doc. But it could be worthwhile to
clarify how postgres behaves also in ALTER doc.
I tested myself and ALTER also ignores ONLY and * for partitioned table
as well.
[1] https://www.postgresql.org/docs/devel/sql-alterpublication.html
---
Name of an existing table. If ONLY is specified before the table_name,
only that table is affected. If ONLY is not specified, the table and all
its descendant tables (if any) are affected. Optionally, * can be
specified after the table_name to explicitly indicate that descendant
tables are included.
---
Regards,
Takeshi Ideriha
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shihao zhong | 2026-10-20 02:20:16 | Re: [PG19] ILIKE index scan misses rows with a libc UTF-8 collation on macOS |
| Previous Message | ZizhuanLiu X-MAN | 2026-10-20 01:47:20 | Re: Optimize MCV stats for sortable types and utilize sorted-order properties |