| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Takeshi Ideriha <iderihatakeshi(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: DOCS - CREATE PUBLICATION wording re 'ONLY' for partitioned tables. |
| Date: | 2026-10-19 08:49:09 |
| Message-ID: | CAJpy0uAy=ww0_ETqU6inSSbdmo2h9NJR5tj6YfMUyDignnHC2Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 19, 2026 at 1:42 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
>
> > On Oct 19, 2026, at 14:57, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > Hi hackers.
> >
> > (This is a DOCS improvement patch only)
> >
> > This patch was originally in another thread, where it was suggested
> > [1] to post separately (here), since it is an independent improvement.
> >
> > ~
> >
> > The "CREATE PUBLICATION" docs [2] say:
> > "This does not apply to a partitioned table, however."
> >
> > It is ambiguous as to exactly what "this" refers to:
> > - does "this" mean just the '*' of the prior sentence?
> > - does "this" relate to the whole 'ONLY'/'*' discussion?
> >
> > The patch removes the ambiguity. PSA v1.
> >
> > ======
> > [1] https://www.postgresql.org/message-id/19bc00e8-ed58-488d-a727-5bca2445b795%40gmail.com
> > [2] https://www.postgresql.org/docs/devel/sql-createpublication.html
> >
> > Kind Regards,
> > Peter Smith.
> > Fujitsu Australia
> > <v1-0001-DOCS-Remove-ambiguous-wording-about-ONLY-for-part.patch>
>
> I think this is an improvement by making the meaning of ONLY and * clearer.
>
> I just have nit comment:
> ```
> + the publication, so they are never explicitly added to the publication.
> ```
>
> “so they are never explicitly added to the publication” might be read as a child partition cannot be added explicitly, however I verified the following is valid:
> ```
> CREATE TABLE p (id integer) PARTITION BY RANGE (id);
> CREATE TABLE p1 PARTITION OF p FOR VALUES FROM (0) TO (100);
> CREATE PUBLICATION pub FOR TABLE p, p1;
> ```
>
> So, how about:
> ```
> the publication, so they do not need to be explicitly added to the
> publication.
> ```
+1. I had the same thought while reviewing. Although the goal here is
just to clarify the point about ONLY, we can also make the subsequent
sentence less ambiguous in the same patch.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-10-19 08:51:41 | Re: query_int wrongly parses zero-padded input |
| Previous Message | Marko Grujic | 2026-10-19 08:30:46 | Re: query_int wrongly parses zero-padded input |