| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Log prefix missing for subscriber log messages received from publisher |
| Date: | 2025-07-22 13:13:31 |
| Message-ID: | CAHGQGwHworHf4he0TyfU9v2W6C7xRk1ePL6piqquVAWZCe4Lng@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 22, 2025 at 9:49 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2025-Jul-22, Fujii Masao wrote:
>
> > On Tue, Jul 22, 2025 at 8:47 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> > > Oh yeah, I should have remembered this -- see commit 213c959a294d. Feel
> > > free to do away with the whole translation thing ... doesn't seem worth
> > > spending more time on it.
> >
> > Yes! The attached patch removes the translation marker and the
> > gettext_noop() calls I recently added.
>
> LGTM.
Thanks for the review!
> > > We should still remove all gettext_noop() markers in contrib :-)
> >
> > You mean to remove gettext_noop() also from basic_archive.c?
>
> Yes, it's useless and misleading. Feel free to do it in the same commit ...
I've included that change in the patch and pushed it. Thanks!
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2025-07-22 13:20:53 | Re: Missing NULL check after calling ecpg_strdup |
| Previous Message | Andrei Lepikhov | 2025-07-22 13:08:37 | Re: Log prefix missing for subscriber log messages received from publisher |