Re: Log prefix missing for subscriber log messages received from publisher

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Log prefix missing for subscriber log messages received from publisher
Date: 2025-07-23 03:46:22
Message-ID: CALDaNm0qcFjzT-Qry0bXv20_ntEO-gXJ-ujHjC1zFd8HVy7Emg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 22 Jul 2025 at 18:43, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Tue, Jul 22, 2025 at 9:49 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> >
> > On 2025-Jul-22, Fujii Masao wrote:
> >
> > > On Tue, Jul 22, 2025 at 8:47 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> >
> > > > Oh yeah, I should have remembered this -- see commit 213c959a294d. Feel
> > > > free to do away with the whole translation thing ... doesn't seem worth
> > > > spending more time on it.
> > >
> > > Yes! The attached patch removes the translation marker and the
> > > gettext_noop() calls I recently added.
> >
> > LGTM.
>
> Thanks for the review!
>
>
> > > > We should still remove all gettext_noop() markers in contrib :-)
> > >
> > > You mean to remove gettext_noop() also from basic_archive.c?
> >
> > Yes, it's useless and misleading. Feel free to do it in the same commit ...
>
> I've included that change in the patch and pushed it. Thanks!

Thanks Fuji-san for handling and pushing this issue.

Regards,
Vignesh

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Japin Li 2025-07-23 03:58:31 Re: [WIP]Vertical Clustered Index (columnar store extension) - take2
Previous Message Michael Paquier 2025-07-23 03:23:37 Re: Verify predefined LWLocks tranches have entries in wait_event_names.txt