| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Log prefix missing for subscriber log messages received from publisher |
| Date: | 2025-07-22 12:49:35 |
| Message-ID: | 202507221249.6klffgfazuxa@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Jul-22, Fujii Masao wrote:
> On Tue, Jul 22, 2025 at 8:47 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> > Oh yeah, I should have remembered this -- see commit 213c959a294d. Feel
> > free to do away with the whole translation thing ... doesn't seem worth
> > spending more time on it.
>
> Yes! The attached patch removes the translation marker and the
> gettext_noop() calls I recently added.
LGTM.
> > We should still remove all gettext_noop() markers in contrib :-)
>
> You mean to remove gettext_noop() also from basic_archive.c?
Yes, it's useless and misleading. Feel free to do it in the same commit ...
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"The ability of users to misuse tools is, of course, legendary" (David Steele)
https://postgr.es/m/11b38a96-6ded-4668-b772-40f992132797@pgmasters.net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2025-07-22 12:51:46 | Re: pgsql: Log remote NOTICE, WARNING, and similar messages using ereport() |
| Previous Message | Joel Jacobson | 2025-07-22 12:48:00 | Re: Proposal: Out-of-Order NOTIFY via GUC to Improve LISTEN/NOTIFY Throughput |