| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, jian(dot)universality(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f'). |
| Date: | 2026-06-18 16:12:08 |
| Message-ID: | CAHGQGwHuPmN+wF7r8zztyBRTJ6Ziq6M1uy2AOO9rPFQKBK+Caw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 18, 2026 at 11:46 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> Hello,
>
> I would dearly appreciate it if you could make these errors in this
> style:
>
> ereport(ERROR,
> (errcode(ERRCODE_WRONG_OBJECT_TYPE),
> /* translator: first %s is a CREATE FUNCTION clause, eg. "IGNORE NULLS" */
> errmsg("%s specified, but %s is not a window function",
> "RESPECT/IGNORE NULLS", NameListToString(funcname)),
> parser_errposition(pstate, location)));
>
> to avoid keeping the clause name in the translatable string.
Thanks for the suggestion! I've updated the patch accordingly.
Patch attached.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Refine-error-reporting-for-null-treatment-on-non-.patch | application/octet-stream | 5.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-06-18 16:14:47 | Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f'). |
| Previous Message | Álvaro Herrera | 2026-06-18 16:08:12 | Re: AW: PG19beta1: GCC 16.1.1 warning: ‘actual_arg_types’ may be used uninitialized in clauses.c |