| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | li(dot)evan(dot)chao(at)gmail(dot)com, jian(dot)universality(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f'). |
| Date: | 2026-06-18 16:14:47 |
| Message-ID: | CAHGQGwHOpAa5HyBvCHYxGGd1LLd37npn0mBxvosFY+w7f2Jgjw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 18, 2026 at 5:28 PM Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>
> > I've updated the patch accordingly.
> >
> > I removed "is" from "RESPECT/IGNORE NULLS is specified" to match other
> > similar error messages, which use the form "XXX specified, ...".
> >
> > + if (ignore_nulls != NO_NULLTREATMENT)
> > + ereport(ERROR,
> > + (errcode(ERRCODE_WRONG_OBJECT_TYPE),
>
> The errcode field can start without a parenthesis:
>
> errcode(ERRCODE_WRONG_OBJECT_TYPE),
Yes, but other similar ereport() calls in parse_func.c also start
the errcode field with a parenthesis, so I followed the same style
here.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2026-06-18 16:20:15 | Re: [PATCH] Doc: document standard_conforming_strings dump/restore incompatibility |
| Previous Message | Fujii Masao | 2026-06-18 16:12:08 | Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f'). |