Re: CI failure: postgres_fdw_get_connections

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CI failure: postgres_fdw_get_connections
Date: 2026-07-16 15:54:05
Message-ID: CAHGQGwHr1EbJZE6P0e5kh=HZneOz5nX0m6YLmc_wbvWh0ZuGJg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 15, 2026 at 11:50 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 15 Jul 2026, at 16:30, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> >
> > On Sun, Jun 14, 2026 at 12:18 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> >>
> >> On Fri, Jun 12, 2026 at 12:27 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> >>> The attached patch implements this approach.
> >>
> >> This seems reasonable to me on a quick glance. Thanks for working on it!
> >
> > Barring any objections, I will commit this patch and backpatch it to v18,
> > where the affected postgres_fdw_get_connections() test was added.
>
> LGTM. I'm not sure we need the timeout on pg_terminate_backend? That's
> however not introduced with this patch, the postgres_fdw tests already use a
> 180s timeout, so keeping it consistent with the rest of the test code seems
> correct.

Thanks for the review! I've pushed the patch.

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2026-07-16 15:55:54 Re: Fix publisher-side sequence permission reporting
Previous Message Paul A Jungwirth 2026-07-16 15:35:39 Re: Fix RLS checks for UPDATE/DELETE FOR PORTION OF leftover rows