| From: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: Fix RLS checks for UPDATE/DELETE FOR PORTION OF leftover rows |
| Date: | 2026-07-16 15:35:39 |
| Message-ID: | CA+renyX3xny=og54iiOcVe0C0kLqEX+4cBg4cF-odE9eXN_8QA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 15, 2026 at 6:10 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> Actually, when I received v4, I was also working on addressing Dean’s comments.
>
> I reviewed both v4 and v5, made some small adjustments, and here is v6:
>
> * For the create_policy doc change, I changed “check new row” to “check leftover rows”.
> * For the “SELECT rights” comment, I moved it into the block comment, because its position in v5 looked like a placeholder.
> * For the tests, v4 and v5 added the new cases in the MERGE section. I added the test in a more direct section.
> * For the tests, v4 and v5 granted INSERT privilege. V6 intentionally does not, because the test runs UPDATE/DELETE FOR PORTION OF, and INSERT privilege is not required for inserting leftover rows by design.
I took a look. These all seem like improvements to me.
Yours,
--
Paul ~{:-)
pj(at)illuminatedcomputing(dot)com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-07-16 15:54:05 | Re: CI failure: postgres_fdw_get_connections |
| Previous Message | Jacob Champion | 2026-07-16 15:21:43 | Re: PG20 Minimum Dependency Thread |