| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: CI failure: postgres_fdw_get_connections |
| Date: | 2026-07-15 14:50:14 |
| Message-ID: | C24EE5A0-1E5A-49F8-B52D-6894D49C27B3@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 15 Jul 2026, at 16:30, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Sun, Jun 14, 2026 at 12:18 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>
>> On Fri, Jun 12, 2026 at 12:27 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>> The attached patch implements this approach.
>>
>> This seems reasonable to me on a quick glance. Thanks for working on it!
>
> Barring any objections, I will commit this patch and backpatch it to v18,
> where the affected postgres_fdw_get_connections() test was added.
LGTM. I'm not sure we need the timeout on pg_terminate_backend? That's
however not introduced with this patch, the postgres_fdw tests already use a
180s timeout, so keeping it consistent with the rest of the test code seems
correct.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-07-15 14:53:40 | Re: Fix GROUP BY ALL handling of ORDER BY operator semantics |
| Previous Message | Robert Haas | 2026-07-15 14:44:12 | Re: implement CAST(expr AS type FORMAT 'template') |