Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: Japin Li <japinli(at)hotmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect
Date: 2025-12-25 07:00:04
Message-ID: CAHGQGwHp28BJiCR59DCzPzUpetDtusNigta7aAC+yiL1dBFb-w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 20, 2025 at 12:48 AM Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>
> On Fri, 19 Dec 2025 at 19:42, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> >
> > On Fri, Dec 19, 2025 at 9:30 PM Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> > > I checked the new TAP test 0002 changes. I am wondering, why are
> > > connection options validated so late in this test? I mean, we do
> > > ALTER PUBLICATION, then we restart publisher, wait for catchup, check
> > > alter publication, and etc, and only then we look if connection
> > > options are indeed applied?
> >
> > Are you suggesting testing whether the conninfo setting is applied earlier,
> > for example, right after both running ALTER SUBSCRIPTION CONNECTION and
> > confirming that the logical replication connection is re-established?
> > Yeah, that might be better and would also make the test easier to read.
> >
> > Regards,
> >
> > --
> > Fujii Masao
>
> Yes, exactly

OK, I've updated the 0002 patch accordingly.

Regards,

--
Fujii Masao

Attachment Content-Type Size
v7-0001-PG15-PG16-Honor-GUC-settings-specified-in-CREATE-SUBSCRIPTI.txt text/plain 5.6 KB
v7-0002-Add-TAP-test-for-GUC-settings-passed-via-CONNECTI.patch application/octet-stream 3.2 KB
v7-0001-Honor-GUC-settings-specified-in-CREATE-SUBSCRIPTI.patch application/octet-stream 5.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2025-12-25 07:01:28 Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect
Previous Message Chao Li 2025-12-25 06:55:50 Re: Fix typos: 'Bejing' to 'Beijing' in partition regress/docs