Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Japin Li <japinli(at)hotmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect
Date: 2025-12-19 15:48:39
Message-ID: CALdSSPgFvTQ196xniNqbMVzZe=-FQY1z5gD6m1GSdO_XRHkhjg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 19 Dec 2025 at 19:42, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Fri, Dec 19, 2025 at 9:30 PM Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> > I checked the new TAP test 0002 changes. I am wondering, why are
> > connection options validated so late in this test? I mean, we do
> > ALTER PUBLICATION, then we restart publisher, wait for catchup, check
> > alter publication, and etc, and only then we look if connection
> > options are indeed applied?
>
> Are you suggesting testing whether the conninfo setting is applied earlier,
> for example, right after both running ALTER SUBSCRIPTION CONNECTION and
> confirming that the logical replication connection is re-established?
> Yeah, that might be better and would also make the test easier to read.
>
> Regards,
>
> --
> Fujii Masao

Yes, exactly

--
Best regards,
Kirill Reshke

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2025-12-19 16:00:29 Re: [PATCH] Documentation
Previous Message Paul A Jungwirth 2025-12-19 15:39:33 Re: ditaa --svg option is missing when building doc/src/sgml/images