Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect
Date: 2025-12-25 07:01:28
Message-ID: CAHGQGwEYsmVotxXs2-c7-qOBbpH1Xad+m=Xed_hWeboF3ziJgQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 23, 2025 at 2:05 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> Thanks, the idea looks good now. One minor comment:

Thanks for the review!

> }
> +
> /*
>
> This appears to be an unnecessary addition in the patch.

The added blank line is due to pgindent, so I didn't exclude it from the patch.
I'm not sure what the preferred practice is for handling pgindent changes
in older branches, but in general it seems better to keep the code clean
and pgindent-compliant even there. Thoughts?

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirill Reshke 2025-12-25 07:19:59 Re: Fix typos: 'Bejing' to 'Beijing' in partition regress/docs
Previous Message Fujii Masao 2025-12-25 07:00:04 Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect