| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | masao(dot)fujii(at)gmail(dot)com |
| Cc: | li(dot)evan(dot)chao(at)gmail(dot)com, jian(dot)universality(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f'). |
| Date: | 2026-06-18 08:27:47 |
| Message-ID: | 20260618.172747.2182002796211305818.ishii@postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I've updated the patch accordingly.
>
> I removed "is" from "RESPECT/IGNORE NULLS is specified" to match other
> similar error messages, which use the form "XXX specified, ...".
>
> + if (ignore_nulls != NO_NULLTREATMENT)
> + ereport(ERROR,
> + (errcode(ERRCODE_WRONG_OBJECT_TYPE),
The errcode field can start without a parenthesis:
errcode(ERRCODE_WRONG_OBJECT_TYPE),
Other than that the patch looks good to me.
Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xuneng Zhou | 2026-06-18 08:36:32 | Re: Fix race in ReplicationSlotRelease for ephemeral slots |
| Previous Message | Hayato Kuroda (Fujitsu) | 2026-06-18 08:27:10 | RE: Why is the LSN reported for pg_logical_emit_message() different from other decoded operations? |