From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: [HACKERS] Creating backup history files for backups taken from standbys |
Date: | 2018-02-01 15:47:26 |
Message-ID: | CAHGQGwHNpL6ENuj+=FWCUXNJvbfd6nYAqR3fNuSFio+D5yF6JQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jan 11, 2018 at 9:47 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Thu, Jan 11, 2018 at 07:10:50PM +0900, Masahiko Sawada wrote:
>> On Sun, Jan 7, 2018 at 1:35 AM, David Steele <david(at)pgmasters(dot)net> wrote:
>>> On 1/6/18 3:48 AM, Michael Paquier wrote:
>>>> On Fri, Jan 5, 2018 at 11:27 PM, Simon Riggs <simon(at)2ndquadrant(dot)com>
>>>> wrote:
>>>>
>>>>> Which also makes it a smaller and clearer patch
>>>>
>>>> Yes, this generates less diffs, reducing the likelihood of bugs. What
>>>> do you think about the v3 attached?
>>>
>>>
>>> I agree that this is a cleaner solution.
>>>
>>
>> +1. And the changes looks good to me.
The patch basically looks good to me. Here are some small comments.
<para>
The backup history file is not created in the database cluster backed up.
</para>
The above should be deleted in pg_basebackup.sgml.
* During recovery, since we don't use the end-of-backup WAL
* record and don't write the backup history file, the
This comment needs to be updated in xlog.c.
Regards,
--
Fujii Masao
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2018-02-01 15:54:51 | git instructions |
Previous Message | Robert Haas | 2018-02-01 15:39:33 | Re: Wait for parallel workers to attach |