| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [HACKERS] Creating backup history files for backups taken from standbys |
| Date: | 2018-02-02 05:06:50 |
| Message-ID: | 20180202050650.GA5451@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 02, 2018 at 12:47:26AM +0900, Fujii Masao wrote:
> The patch basically looks good to me. Here are some small comments.
>
> <para>
> The backup history file is not created in the database cluster backed up.
> </para>
>
> The above should be deleted in pg_basebackup.sgml.
>
> * During recovery, since we don't use the end-of-backup WAL
> * record and don't write the backup history file, the
>
> This comment needs to be updated in xlog.c.
Thanks Fujii-san for the review. Indeed those portions need a refresh..
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| standby-backup-history-v4.patch | text/x-diff | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2018-02-02 05:22:34 | Re: JIT compiling with LLVM v9.0 |
| Previous Message | Michael Paquier | 2018-02-02 04:22:24 | Re: [PoC PATCH] Parallel dump to /dev/null |