| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, jian(dot)universality(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f'). |
| Date: | 2026-06-23 05:55:57 |
| Message-ID: | CAHGQGwH-PcHSoTW0yROtAFXLex0ZTWDdr=nwrkoZ1ZyLu-KzTA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 19, 2026 at 1:12 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Thu, Jun 18, 2026 at 11:46 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> >
> > Hello,
> >
> > I would dearly appreciate it if you could make these errors in this
> > style:
> >
> > ereport(ERROR,
> > (errcode(ERRCODE_WRONG_OBJECT_TYPE),
> > /* translator: first %s is a CREATE FUNCTION clause, eg. "IGNORE NULLS" */
> > errmsg("%s specified, but %s is not a window function",
> > "RESPECT/IGNORE NULLS", NameListToString(funcname)),
> > parser_errposition(pstate, location)));
> >
> > to avoid keeping the clause name in the translatable string.
>
> Thanks for the suggestion! I've updated the patch accordingly.
> Patch attached.
Barring any objections, I will commit the patch.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christophe Pettus | 2026-06-23 06:15:33 | Re: The PostgreSQL C Dialect |
| Previous Message | Sutou Kouhei | 2026-06-23 05:41:49 | Re: Make COPY format extendable: Extract COPY TO format implementations |