Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: masao(dot)fujii(at)gmail(dot)com
Cc: alvherre(at)kurilemu(dot)de, li(dot)evan(dot)chao(at)gmail(dot)com, jian(dot)universality(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').
Date: 2026-06-23 11:37:51
Message-ID: 20260623.203751.1338229248826161375.ishii@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Fri, Jun 19, 2026 at 1:12 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>
>> On Thu, Jun 18, 2026 at 11:46 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>> >
>> > Hello,
>> >
>> > I would dearly appreciate it if you could make these errors in this
>> > style:
>> >
>> > ereport(ERROR,
>> > (errcode(ERRCODE_WRONG_OBJECT_TYPE),
>> > /* translator: first %s is a CREATE FUNCTION clause, eg. "IGNORE NULLS" */
>> > errmsg("%s specified, but %s is not a window function",
>> > "RESPECT/IGNORE NULLS", NameListToString(funcname)),
>> > parser_errposition(pstate, location)));
>> >
>> > to avoid keeping the clause name in the translatable string.
>>
>> Thanks for the suggestion! I've updated the patch accordingly.
>> Patch attached.
>
> Barring any objections, I will commit the patch.

No objection from me.
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message solai v 2026-06-23 11:39:10 Re: Support EXCEPT for ALL SEQUENCES publications
Previous Message Euler Taveira 2026-06-23 11:35:42 Re: doc: should pg_createsubscriber be grouped as a client application?