Re: analyze-in-stages post upgrade questions

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: Mircea Cadariu <cadariu(dot)mircea(at)gmail(dot)com>, "Zechman, Derek S" <Derek(dot)S(dot)Zechman(at)snapon(dot)com>, Adrian Klaver <adrian(dot)klaver(at)aklaver(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: analyze-in-stages post upgrade questions
Date: 2025-08-18 02:38:23
Message-ID: CAHGQGwGje3mv5sOmyCJ0NroNPF8938OYCOHMJZbegTekccZZ=g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Thu, Aug 7, 2025 at 5:52 AM Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> wrote:
> > I understand your point. But on second thought, since the patch changes
> > behavior, I'm leaning toward treating it as an improvement, so it should
> > only go to master...
>
> I agree that this behavior change should not be backpatched.
> That is not a bugfix.

+1

> > --------------------
> > vacuumdb should generally follow the behavior of the underlying
> > VACUUM and ANALYZE commands. If analyze_only is true, process
> > regular tables, materialized views, and partitioned tables, just like
> > ANALYZE (with no specific target tables) does. Otherwise, process
> > only regular tables and materialized views, since VACUUM skips
> > partitioned tables when no target tables are specified.
> > --------------------
>
> I am fine with that suggestion.

Thanks! So I've updated the patch based on my earlier comments.
Unless there are objections, I'll commit the attached version to master only.

Regards,

--
Fujii Masao

Attachment Content-Type Size
v3-0001-vacuumdb-Make-vacuumdb-analyze-only-process-parti.patch application/octet-stream 4.8 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Laurenz Albe 2025-08-18 06:40:02 Re: analyze-in-stages post upgrade questions
Previous Message Fujii Masao 2025-08-18 02:36:48 Re: analyze-in-stages post upgrade questions

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-08-18 02:48:08 Re: Improve hash join's handling of tuples with null join keys
Previous Message Fujii Masao 2025-08-18 02:36:48 Re: analyze-in-stages post upgrade questions