| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Sugamoto Shinya <shinya34892(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions |
| Date: | 2025-11-17 14:59:39 |
| Message-ID: | CAHGQGwGbYqzvBGOK44w+t48SvKJGR7iD9BGjf0nk1uvGT7P1Rg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 17, 2025 at 11:30 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 17 Nov 2025, at 15:08, Sugamoto Shinya <shinya34892(at)gmail(dot)com> wrote:
>
> > I ordered the valid encodings alphabetically and extracted those into separate parameters.
>
> LGTM. Per project style I don't think we should quote the names of encodings
> since they are visibly not English words (see commit a243569bf65c5 which deals
> with variable names, but I think it applies here as well)
It looks like the message-style rule added in commit a243569bf65c5
applies only to
configuration parameter names, right? And it seems that rule was later revised
by commit 17974ec2594. Is that correct?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2025-11-17 15:04:17 | Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions |
| Previous Message | Vaibhav Dalvi | 2025-11-17 14:44:25 | Re: [PATCH] Add pg_get_subscription_ddl() function |