Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Sugamoto Shinya <shinya34892(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions
Date: 2025-11-17 14:30:41
Message-ID: 87834521-330D-45EF-B91F-889B484D15EC@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 17 Nov 2025, at 15:08, Sugamoto Shinya <shinya34892(at)gmail(dot)com> wrote:

> I ordered the valid encodings alphabetically and extracted those into separate parameters.

LGTM. Per project style I don't think we should quote the names of encodings
since they are visibly not English words (see commit a243569bf65c5 which deals
with variable names, but I think it applies here as well), but no need to send
another version of the patch just for that small adjustment.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Timur Magomedov 2025-11-17 14:32:34 Re: [WIP]Vertical Clustered Index (columnar store extension) - take2
Previous Message Manni Wood 2025-11-17 14:24:04 Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement