| From: | Xiaopeng Wang <wxp_728(at)163(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid |
| Date: | 2026-04-16 05:27:13 |
| Message-ID: | 9cbbd8fc-4e46-495d-8260-a267196a1826@163.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
在 2026/4/16 12:11, Fujii Masao 写道:
> On Mon, Apr 13, 2026 at 4:10 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>> I felt these also should be updated, the attached v2 version patch
>> includes the changes for the same.
> Thanks for updating the patch!
>
> - applyPtr = (latestApplyPtr == InvalidXLogRecPtr) ?
> + applyPtr = (XLogRecPtrIsInvalid(latestApplyPtr)) ?
>
> XLogRecPtrIsValid() should be used here, instead?
>
> Regards,
>
Yeah, I was about to raise the same comment, and Fujii-san beat me. I believe it should be XLogRecPtrIsValid().
Otherwise, the patch looks good to me.
Regards,
Xiaopeng Wang
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2026-04-16 05:47:58 | Re: First draft of PG 19 release notes |
| Previous Message | Amit Langote | 2026-04-16 05:17:22 | Re: [PATCH] Fix wrong comment in JsonTablePlanJoinNextRow() |