| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Standby accepts recovery_target_timeline setting? |
| Date: | 2019-09-29 16:36:55 |
| Message-ID: | CAHGQGwFxZOP_V_udboLm=0g8UHN195GYa_bc9jchx_Ui47812g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Sep 29, 2019 at 6:08 AM Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> On 2019-09-28 19:45, Tom Lane wrote:
> > Maybe I'm misunderstanding, but I think that rather than adding error
> > checks that were not there before, the right path to fixing this is
> > to cause these settings to be ignored if we're doing crash recovery.
>
> That makes sense to me.
+1
> Something like this (untested)?
Yes, but ArchiveRecoveryRequested should be checked instead of
InArchiveRecovery, I think. Otherwise recovery targets would take effect
when recovery.signal is missing but backup_label exists. In this case,
InArchiveRecovery is set to true though ArchiveRecoveryRequested is
false because recovery.signal is missing.
With the attached patch, I checked that the steps that I described
upthread didn't reproduce the issue.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| ignore-recovery-targets-in-crash-recovery.patch | application/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-09-29 17:30:44 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
| Previous Message | Alexander Korotkov | 2019-09-29 16:27:28 | Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock(PG10.7) |