| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Standby accepts recovery_target_timeline setting? |
| Date: | 2019-09-29 21:59:08 |
| Message-ID: | ad8b26c3-3e18-3308-0956-92bffd3c3c4b@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-09-29 18:36, Fujii Masao wrote:
> Yes, but ArchiveRecoveryRequested should be checked instead of
> InArchiveRecovery, I think. Otherwise recovery targets would take effect
> when recovery.signal is missing but backup_label exists. In this case,
> InArchiveRecovery is set to true though ArchiveRecoveryRequested is
> false because recovery.signal is missing.
>
> With the attached patch, I checked that the steps that I described
> upthread didn't reproduce the issue.
Your patch looks correct to me.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2019-09-29 22:43:07 | typo: postGER |
| Previous Message | Peter Eisentraut | 2019-09-29 21:30:56 | Re: v12 relnotes: alter system tables |