From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Remove pg_stat_progress_vacuum from Table 28.2 |
Date: | 2017-04-13 03:11:33 |
Message-ID: | CAHGQGwFstH_NAZpy7ir5F6BoPD_gWSraatSJTJ+zy7b5WEatVQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Apr 12, 2017 at 10:32 AM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> On 2017/04/12 0:22, Fujii Masao wrote:
>> On Fri, Apr 7, 2017 at 9:53 AM, Amit Langote
>> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>> On 2017/04/07 0:56, Fujii Masao wrote:
>>>> On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote
>>>> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>>>> It seems pg_stat_progress_vacuum is not supposed to appear in the table
>>>>> titled "Collected Statistics Views". It was added by c16dc1aca. Attached
>>>>> patch fixes that.
>>>>
>>>> Instead, it should appear in the table of "Dynamic Statistics Views"
>>>> because it reports dynamic info, i.e., progress, about VACUUM activity?
>>>
>>> I thought the same at first, but then realized we have a entirely separate
>>> section 28.4. Progress Reporting.
>>
>> Yes, but I don't think that removing that from 28.2 is an improvement
>> for users.
>
> Perhaps you're right. Here's a patch that moves pg_stat_progress_vacuum
> to the Dynamic Statistics Views table.
Thanks for the patch! Pushed.
Regards,
--
Fujii Masao
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2017-04-13 03:28:00 | Re: logical replication and PANIC during shutdown checkpoint in publisher |
Previous Message | Euler Taveira | 2017-04-13 03:04:59 | Different table schema in logical replication crashes |