Re: Remove pg_stat_progress_vacuum from Table 28.2

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove pg_stat_progress_vacuum from Table 28.2
Date: 2017-04-12 01:32:24
Message-ID: 2d80555e-ca63-99db-bf0f-ecf34e0d9ccb@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017/04/12 0:22, Fujii Masao wrote:
> On Fri, Apr 7, 2017 at 9:53 AM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> On 2017/04/07 0:56, Fujii Masao wrote:
>>> On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote
>>> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>>> It seems pg_stat_progress_vacuum is not supposed to appear in the table
>>>> titled "Collected Statistics Views". It was added by c16dc1aca. Attached
>>>> patch fixes that.
>>>
>>> Instead, it should appear in the table of "Dynamic Statistics Views"
>>> because it reports dynamic info, i.e., progress, about VACUUM activity?
>>
>> I thought the same at first, but then realized we have a entirely separate
>> section 28.4. Progress Reporting.
>
> Yes, but I don't think that removing that from 28.2 is an improvement
> for users.

Perhaps you're right. Here's a patch that moves pg_stat_progress_vacuum
to the Dynamic Statistics Views table.

Thanks,
Amit

Attachment Content-Type Size
0001-Move-pg_stat_progress_vacuum-to-Table-28.1.patch text/x-diff 1.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2017-04-12 02:13:02 Re: error handling in RegisterBackgroundWorker
Previous Message Bruce Momjian 2017-04-12 01:25:32 Re: Some thoughts about SCRAM implementation