Re: Extend documentation for pg_stat_replication.backend_xmin

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Renzo Dani <arons7(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Extend documentation for pg_stat_replication.backend_xmin
Date: 2025-10-16 03:31:57
Message-ID: CAHGQGwEfGkCwfzuTGrW4HSY0BK0DK5fVi_HCS3O9VO2qEc7z_A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 16, 2025 at 12:47 AM Renzo Dani <arons7(at)gmail(dot)com> wrote:
>
> Hi,
> recently I had some issue understanding what was going on with a replica and the reported xmin.
> I have than created a patch to better specify the value expected into the pg_stat_replication.backend_xmin field.

+1

+ This field will be null if a replication slot is used; in that
case, the xmin is available through <link
linkend="view-pg-replication-slots">pg_replication_slots</link>.

I think it would be better to also mention that this field is null
when hot_standby_feedback is disabled.

Also, <literal> tags should be used for "xmin", and a newline should
be added to avoid an overly long line.

Based on the above comments, how about revising it as follows?

+ This field will be null if a replication slot is used (in this case,
+ the standby's <literal>xmin</literal> is shown in
+ <link linkend="view-pg-replication-slots">pg_replication_slots</link>)
+ or if <varname>hot_standby_feedback</varname> is disabled.

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-10-16 03:37:01 Re: [PROPOSAL] Termination of Background Workers for ALTER/DROP DATABASE
Previous Message jian he 2025-10-16 03:28:43 Re: doc: create table improvements