| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "tyler(at)smarts(dot)io" <tyler(at)smarts(dot)io>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #19616: pgoutput sends stream abort ('A') to clients that did not enable streaming |
| Date: | 2026-08-14 12:33:08 |
| Message-ID: | CAHGQGwE0MkAqsZa_=PfX65VHwv8Cqh0sst0x_HH8eF56M6Fmpg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Aug 14, 2026 at 3:45 PM Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com> wrote:
> I have updated the patch with the suggested changes.
Thanks for updating the patch! LGTM.
One minor comment: ReorderBufferMaybeMarkTXNStreamed() seems to rely on
the assumption that it is never called for a top-level transaction when
streaming is disabled. If that's correct, how about documenting this
assumption in the function comment and/or adding an assertion such as:
if (rbtxn_is_toptxn(txn))
{
Assert(ReorderBufferCanStream(rb));
txn->txn_flags |= RBTXN_IS_STREAMED;
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Rachitskiy | 2026-08-14 13:59:45 | Re: BUG #19613: pg_restore: several SEGVs in ReadToc() in pg_backup_archiver.c |
| Previous Message | Peter Eisentraut | 2026-08-14 12:01:45 | Re: DELETE FOR PORTION OF bypasses view WITH CHECK OPTION for leftover rows |