Re: BUG #19613: pg_restore: several SEGVs in ReadToc() in pg_backup_archiver.c

пт, 14 авг. 2026 г. в 16:58, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>:

> Could we add a regression test? The reporter's reproducer is short and
> looks cool, needs no server, and could fit naturally in t/001_basic.pl. A
> command_fails_like() check for the new "missing table OID in TOC" error
> would prove that the original crash is fixed and protect the new helper.
>
> It might be worth covering the other four call sites too, but I would
> consider the original reproducer sufficient for this patch.
>
Hi Andrey!

Thanks for the review.

I added a regression test, attached as v2. It goes into
src/bin/pg_dump/t/001_basic.pl next to the other checks that need no
server. Rather than just the reporter's reproducer, it now covers every
ReadRequiredStr() call site in ReadToc(). The test builds a handful of
minimal custom-format archives, each with exactly one required TOC field
encoded as a NULL string (table OID, OID, entry tag, entry description
and the WITH OIDS marker), and uses command_fails_like() to require the
matching "missing <field> in TOC" error. The archive bytes are produced
by two tiny helpers.

The test does not depend on anything version-specific. It writes an
archive with a 1.12 header, a version every supported branch still reads,
and ReadToc() consumes those TOC fields in the same order on all of them.
The nullable fields it walks past are written as NULL, and the newer
fields (tableam, relkind) are gated on later versions and simply not
present at 1.12, so the same bytes exercise the same call sites from 14
to master. Valid archives are unaffected.

The test was checked on all releases from master to REL_14_STABLE

--
Regards,
Rachitskiy Andrey