| From: | Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "tyler(at)smarts(dot)io" <tyler(at)smarts(dot)io>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #19616: pgoutput sends stream abort ('A') to clients that did not enable streaming |
| Date: | 2026-08-14 14:34:50 |
| Message-ID: | CAB8bMisGEQ02trVibY5GGwfp9NdEZC-dJARNKd25AVnzLeogNQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
пт, 14 авг. 2026 г. в 17:33, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>:
> One minor comment: ReorderBufferMaybeMarkTXNStreamed() seems to rely on
> the assumption that it is never called for a top-level transaction when
> streaming is disabled. If that's correct, how about documenting this
> assumption in the function comment and/or adding an assertion such as:
>
> if (rbtxn_is_toptxn(txn))
> {
> Assert(ReorderBufferCanStream(rb));
> txn->txn_flags |= RBTXN_IS_STREAMED;
>
> Dear Fujii-san,
Thanks for the review.
v4 with assert and comment, in attachment.
--
Regards,
Rachitskiy Andrey
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Don-t-mark-discarded-aborted-subxacts-as-streamed.patch | text/x-patch | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-08-14 14:36:37 | Re: MERGE/SPLIT PARTITIONS issues/questions |
| Previous Message | Fujii Masao | 2026-08-14 14:08:49 | Re: BUG #19598: pg_waldump: -s/-e accept out-of-range WAL locations and silently use the low 32 bits |