Re: CI: Add task that runs pgindent

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Jelte Fennema-Nio <me(at)jeltef(dot)nl>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Subject: Re: CI: Add task that runs pgindent
Date: 2025-10-23 15:14:18
Message-ID: CAH2-Wzm674VS63sbv5LBJunH=hJ_n1iBBt0iyUiWwpgDFpp1RA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 22, 2025 at 8:07 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> I like the different shape and symbol, but I would probably keep it green to
> indicate that it's informational rather than actionable. We don't want a
> flurry of patch re-submissions with only whitespace changes eating CI resources
> when the previous build was successful. Just my €0,02.

I strongly agree that this shouldn't signal to the user that they
really need to fix the problem. I'd like it if this information was
presented in the least obtrusive way possible. Constantly worrying
about a misplaced tab is a waste of time for all concerned.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2025-10-23 15:14:56 Re: Docs and tests for RLS policies applied by command type
Previous Message Nathan Bossart 2025-10-23 15:11:26 Re: Remove an unnecessary blank line on the PQisBusy() comments