| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Jelte Fennema-Nio <me(at)jeltef(dot)nl> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Subject: | Re: CI: Add task that runs pgindent |
| Date: | 2025-10-22 12:06:44 |
| Message-ID: | 3AFFBE95-BC6B-4A8E-9CE6-D5CA4533D690@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 22 Oct 2025, at 11:24, Jelte Fennema-Nio <me(at)jeltef(dot)nl> wrote:
>
> On Wed, 22 Oct 2025 at 10:49, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> Orange cross and Red cross are probably too similar to be easily discernible
>> for people with color blindness. Since the patch is technically "green", what
>> do you think about just changing the checkmark on such patches?
>
> Good point. I changed it to an orange triangle + exclamation point now
> (see attached). And everything also seems to work as expected in the
> commitfest app prod environment, because this patch now shows as
> correctly as yellow: https://commitfest.postgresql.org/patch/6148/
I like the different shape and symbol, but I would probably keep it green to
indicate that it's informational rather than actionable. We don't want a
flurry of patch re-submissions with only whitespace changes eating CI resources
when the previous build was successful. Just my €0,02.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | BharatDB | 2025-10-22 12:26:41 | Re: Fix ALTER TABLE DROP EXPRESSION with inheritance hierarchy |
| Previous Message | Tim Waizenegger | 2025-10-22 12:00:21 | Re: [PATCH] pg_get_domain_ddl: DDL reconstruction function for CREATE DOMAIN statement |