| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Jelte Fennema-Nio <me(at)jeltef(dot)nl>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Subject: | Re: CI: Add task that runs pgindent |
| Date: | 2025-10-23 15:58:23 |
| Message-ID: | CAKFQuwZEnGhGV32A55PvEF9HUhjEfDAoxcp7rDvSNL2KKx8Kdw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 23, 2025, 11:14 Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Wed, Oct 22, 2025 at 8:07 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > I like the different shape and symbol, but I would probably keep it
> green to
> > indicate that it's informational rather than actionable. We don't want a
> > flurry of patch re-submissions with only whitespace changes eating CI
> resources
> > when the previous build was successful. Just my €0,02.
>
> I strongly agree that this shouldn't signal to the user that they
> really need to fix the problem. I'd like it if this information was
> presented in the least obtrusive way possible. Constantly worrying
> about a misplaced tab is a waste of time for all concerned.
>
My thought is to use the new tags feature to add/remove a "Needs
Formatting" tag as the indicator.
David J.
>
>
>
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Srinath Reddy Sadipiralla | 2025-10-23 16:08:23 | Re: Making pg_rewind faster |
| Previous Message | Tom Lane | 2025-10-23 15:52:14 | Re: Git clone over git protocol fails |