| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com> |
| Subject: | Re: New IndexAM API controlling index vacuum strategies |
| Date: | 2021-04-13 19:59:03 |
| Message-ID: | CAH2-WzkS-gxSNnd2jywep0b=T4au=1j5PgYk8k1bN_NyMBbfVQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 12, 2021 at 11:05 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> I realized that when the failsafe is triggered, we don't bypass heap
> truncation that is performed before updating relfrozenxid. I think
> it's better to bypass it too. What do you think?
I agree. Bypassing heap truncation is exactly the kind of thing that
risks adding significant, unpredictable delay at a time when we need
to advance relfrozenxid as quickly as possible.
I pushed a trivial commit that makes the failsafe bypass heap
truncation as well just now.
Thanks
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-04-13 20:46:25 | Re: [PATCH] Identify LWLocks in tracepoints |
| Previous Message | Tom Lane | 2021-04-13 19:11:38 | Re: pg_upgrade check for invalid role-specific default config |