| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com> |
| Subject: | Re: New IndexAM API controlling index vacuum strategies |
| Date: | 2021-04-14 00:06:07 |
| Message-ID: | CAD21AoB9ZADwHDShBMDtitGV7TWH_NgvhdDEC7MvLwn9f7AErw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 14, 2021 at 4:59 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>
> On Mon, Apr 12, 2021 at 11:05 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > I realized that when the failsafe is triggered, we don't bypass heap
> > truncation that is performed before updating relfrozenxid. I think
> > it's better to bypass it too. What do you think?
>
> I agree. Bypassing heap truncation is exactly the kind of thing that
> risks adding significant, unpredictable delay at a time when we need
> to advance relfrozenxid as quickly as possible.
>
> I pushed a trivial commit that makes the failsafe bypass heap
> truncation as well just now.
Great, thanks!
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-04-14 01:38:17 | Re: Extensions not dumped when --schema is used |
| Previous Message | Tomas Vondra | 2021-04-13 22:55:55 | Re: Uninitialized scalar variable (UNINIT) (src/backend/statistics/extended_stats.c) |