Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Date: 2020-01-04 18:38:49
Message-ID: CAH2-WzkHftVLq1BzbJyXtSD0nf7HC8pAa8UYZwvL4nkSOv1x1A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Jan 4, 2020 at 10:19 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Looking closer, I see that your actual output included *both*
> spaces and escape sequences between the table names, so it
> needs to be more like the attached.

This patch makes the tests pass. Thanks!

> So now I'm thinking again that there must be something about
> your colorized setup that triggers use of at least the first one.
> But why didn't clearing the relevant environment variables
> change anything?

I don't know. It also failed with bash, which doesn't have any of that stuff.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-01-04 19:29:39 pgsql: Make tab-completion tests more robust.
Previous Message Tom Lane 2020-01-04 18:19:28 Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2020-01-04 18:51:48 Re: logical decoding : exceeded maxAllocatedDescs for .spill files
Previous Message Alexey Kondratov 2020-01-04 18:38:24 Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly