pgsql: Make tab-completion tests more robust.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Make tab-completion tests more robust.
Date: 2020-01-04 19:29:39
Message-ID: E1inp7D-0002lD-B1@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make tab-completion tests more robust.

Depending on as-yet-incompletely-explained factors, readline/libedit
might choose to emit screen-control escape sequences as part of
repainting the display. I'd tried to make the test patterns avoid
matching parts of the output that are likely to contain such, but
it seems that there's really no way around matching them explicitly
in some places, unless we want to just give up testing some behaviors
such as display of alternatives.

Per report from Peter Geoghegan.

Discussion: https://postgr.es/m/CAH2-WznPzfWHu8PQwv1Qjpf4wQVPaaWpoO5NunFz9zsYKB4uJA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fac1c04feca6d01f2d324088c5899485f55b6217

Modified Files
--------------
src/bin/psql/t/010_tab_completion.pl | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2020-01-04 19:32:26 pgsql: Skip memcpy(x, x) in qunique().
Previous Message Peter Geoghegan 2020-01-04 18:38:49 Re: pgsql: Add basic TAP tests for psql's tab-completion logic.