On Mon, Apr 8, 2019 at 2:10 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> I'm not sure I understand what the problem is. We got to get the
> information for the fsm from somewhere? Are you arguing we should
> instead have it included as an explicit xlog record payload?
No. I am simply pointing out that PageGetFreeSpace() "should usually
only be used on index pages" according to its own comments. And yet
it's called for other stuff.
Maybe it's not that important in that one instance, but I find it
pretty distracting that PageGetFreeSpace() is intended for index AMs
that use conventional line pointers.
--
Peter Geoghegan