| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: PageGetFreeSpace() isn't quite the right thing for some of its callers |
| Date: | 2019-04-08 21:10:40 |
| Message-ID: | 20190408211040.xxlkidanuqjydlhk@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-04-08 14:05:02 -0700, Peter Geoghegan wrote:
> However, now that I take a closer look I also notice that there is
> core code that calls PageGetFreeSpace() when it probably shouldn't,
> either. For example, what business does heap_xlog_visible() have
> calling PageGetFreeSpace()?
I'm not sure I understand what the problem is. We got to get the
information for the fsm from somewhere? Are you arguing we should
instead have it included as an explicit xlog record payload? Or just
that it should use PageGetExactFreeSpace()? I assume the former based on
your "what business" language, but that'd not make terribly much sense
to me. I don't think precision terribly matters here...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2019-04-08 21:14:48 | Re: PageGetFreeSpace() isn't quite the right thing for some of its callers |
| Previous Message | Tom Lane | 2019-04-08 21:06:55 | Re: change password_encryption default to scram-sha-256? |