| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: PageGetFreeSpace() isn't quite the right thing for some of its callers |
| Date: | 2019-04-09 18:35:21 |
| Message-ID: | CA+TgmoYHk=ttewD7YsNEj8JJTbqpSH8MOTBOe5cfbc-ZK3GAHQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 8, 2019 at 5:15 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Mon, Apr 8, 2019 at 2:10 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > I'm not sure I understand what the problem is. We got to get the
> > information for the fsm from somewhere? Are you arguing we should
> > instead have it included as an explicit xlog record payload?
>
> No. I am simply pointing out that PageGetFreeSpace() "should usually
> only be used on index pages" according to its own comments. And yet
> it's called for other stuff.
>
> Maybe it's not that important in that one instance, but I find it
> pretty distracting that PageGetFreeSpace() is intended for index AMs
> that use conventional line pointers.
Maybe we should rename it.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2019-04-09 18:48:19 | Re: proposal: plpgsql pragma statement |
| Previous Message | Robert Haas | 2019-04-09 18:29:09 | Re: Zedstore - compressed in-core columnar storage |