| From: | wenhui qiu <qiuwenhuifx(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Alexandra Wang <alexandra(dot)wang(dot)oss(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andy Fan <zhihuifan1213(at)163(dot)com> |
| Subject: | Re: Pathify RHS unique-ification for semijoin planning |
| Date: | 2025-08-08 02:21:40 |
| Message-ID: | CAGjGUAKwL-Z4WTZ6C89yXnTeUjGp9v8pPEZx54se=229x_RRow@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Richard
Thanks for your feedback. I agree this approach is better for keeping
the code style consistent.
Thanks
On Fri, Aug 8, 2025 at 9:39 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> On Thu, Aug 7, 2025 at 6:04 PM wenhui qiu <qiuwenhuifx(at)gmail(dot)com> wrote:
> > In light of this commit (
> https://github.com/postgres/postgres/commit/e035863c9a04beeecc254c3bfe48dab58e389e10)
> I also recommend changing the macro to a static inline function. Macros are
> harder to debug and lack type safety.
>
> I'm inclined not to do that. We already have other macros for
> checking whether a relation is of a certain kind, and I'd prefer to
> keep the new check consistent with those.
>
> Thanks
> Richard
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo Nagata | 2025-08-08 02:51:42 | Align tests for stored and virtual generated columns |
| Previous Message | Richard Guo | 2025-08-08 01:39:08 | Re: Pathify RHS unique-ification for semijoin planning |