Align tests for stored and virtual generated columns

From: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
To: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Align tests for stored and virtual generated columns
Date: 2025-08-08 02:51:42
Message-ID: 20250808115142.e9ccb81f35466a9a131a4c55@sraoss.co.jp
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I noticed that the tests for virtual and stored generated columns
contain the following comment;

-- keep these tests aligned with generated_stored.sql (or generated_virtual.sql)

However, it seems that some additional tests for virtual generated columns
disrupted that alignment, as they were not added to generated_stored.sql.

I've attached a patch to restore the alignment.

In addition, I moved the test confirming that user-defined types are not allowed
in virtual generated columns to the generated_virtual.sql-specific section,
since this test is not necessary for stored generated columns.

Regards,
Yugo Nagata

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

Attachment Content-Type Size
0001-Align-tests-for-stored-and-virtual-generated-columns.patch text/x-diff 14.4 KB

Browse pgsql-hackers by date

  From Date Subject
Next Message Shinya Kato 2025-08-08 03:03:30 Re: Improve tab completion for various SET/RESET forms
Previous Message wenhui qiu 2025-08-08 02:21:40 Re: Pathify RHS unique-ification for semijoin planning