Re: Pathify RHS unique-ification for semijoin planning

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: wenhui qiu <qiuwenhuifx(at)gmail(dot)com>
Cc: Alexandra Wang <alexandra(dot)wang(dot)oss(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andy Fan <zhihuifan1213(at)163(dot)com>
Subject: Re: Pathify RHS unique-ification for semijoin planning
Date: 2025-08-08 01:39:08
Message-ID: CAMbWs48p9-_L-ouwbstcBOcSOYQ64CUGxawo_ZzotX55ADG9Zg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 7, 2025 at 6:04 PM wenhui qiu <qiuwenhuifx(at)gmail(dot)com> wrote:
> In light of this commit (https://github.com/postgres/postgres/commit/e035863c9a04beeecc254c3bfe48dab58e389e10) I also recommend changing the macro to a static inline function. Macros are harder to debug and lack type safety.

I'm inclined not to do that. We already have other macros for
checking whether a relation is of a certain kind, and I'd prefer to
keep the new check consistent with those.

Thanks
Richard

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message wenhui qiu 2025-08-08 02:21:40 Re: Pathify RHS unique-ification for semijoin planning
Previous Message Michael Paquier 2025-08-08 01:37:46 Re: Backpatching injection point core facilities to REL_17_STABLE