From: | Jesse Zhang <sbjesse(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: do {} while (0) nitpick |
Date: | 2020-05-04 15:01:56 |
Message-ID: | CAGf+fX6pvwFiK16BuHj81-p2OEPD3Zg2zbn2JobX20YmjwV6cg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Tom,
On Fri, May 1, 2020 at 2:32 PM Tom Lane wrote:
>
> Grepping showed me that there were some not-do-while macros that
> also had trailing semicolons. These seem just as broken, so I
> fixed 'em all.
>
I'm curious: *How* are you able to discover those occurrences with grep?
I understand how John might have done it with his original patch: it's
quite clear the pattern he would look for looks like "while (0);" but
how did you find all these other macro definitions with a trailing
semicolon? My tiny brain can only imagine:
1. Either grep for trailing semicolon (OMG almost every line will come
up) and squint through the context the see the previous line has a
trailing backslash;
2. Or use some LLVM magic to spelunk through every macro definition and
look for a trailing semicolon
Cheers,
Jesse
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-05-04 15:28:37 | Re: do {} while (0) nitpick |
Previous Message | Julien Rouhaud | 2020-05-04 14:32:55 | Re: WAL usage calculation patch |