| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jesse Zhang <sbjesse(at)gmail(dot)com> |
| Cc: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: do {} while (0) nitpick |
| Date: | 2020-05-04 15:28:37 |
| Message-ID: | 5365.1588606117@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jesse Zhang <sbjesse(at)gmail(dot)com> writes:
> On Fri, May 1, 2020 at 2:32 PM Tom Lane wrote:
>> Grepping showed me that there were some not-do-while macros that
>> also had trailing semicolons. These seem just as broken, so I
>> fixed 'em all.
> I'm curious: *How* are you able to discover those occurrences with grep?
Um, well, actually, it was a little perl script with a state variable
to remember whether it was in a macro definition or not (set on seeing
a #define, unset when current line doesn't end with '\', complain if
set and line ends with ';').
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bossart, Nathan | 2020-05-04 17:44:21 | race condition when writing pg_control |
| Previous Message | Jesse Zhang | 2020-05-04 15:01:56 | Re: do {} while (0) nitpick |